Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long string truncation with ellipsis #24

Closed
sedghi opened this issue Feb 25, 2022 · 7 comments
Closed

long string truncation with ellipsis #24

sedghi opened this issue Feb 25, 2022 · 7 comments

Comments

@sedghi
Copy link

sedghi commented Feb 25, 2022

I just joined the users for your plugin, first of all great work! it looks amazing.

Immediate thing that caught my attention was that when the names are long, the layout just gets crazy and breaks into new line. Can we have a check for long strings to truncate after some number of letters?

image

@B4nan
Copy link
Contributor

B4nan commented Feb 26, 2022

I also suffer from this, but it can be (and probably should be) handled via CSS (text-overflow: ellipsis) instead of hard truncate on server side, which is easily workaroundable.

Note that the same problem is in the local sidebar on the right side.

@milesj
Copy link
Owner

milesj commented Feb 26, 2022

These styles are just Docusaurus itself, as I reuse the same styles from the docs pages.

Let me see if I can override it.

@milesj
Copy link
Owner

milesj commented Feb 27, 2022

Fixed in 1.8

@milesj milesj closed this as completed Feb 27, 2022
@sedghi
Copy link
Author

sedghi commented Feb 28, 2022

Great, thanks!

@B4nan
Copy link
Contributor

B4nan commented Feb 28, 2022

Looks the same on my end 🤷

image

image

https://apify.github.io/apify-ts/api/next/cheerio-crawler

@sedghi
Copy link
Author

sedghi commented Feb 28, 2022

Yes, the truncation is not done, but the rows start at the same level now. At least that is what I see

@milesj
Copy link
Owner

milesj commented Feb 28, 2022

I don't truncate, I break word, so the bottom screenshot is correct. The top screenshot is just... unfortunate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants