Improve error messages a bit, show hint when no registrations are found

mileskin · Apr 23, 2012 · d74c558 · d74c558
1 parent e8a1281
commit d74c558
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/jasmine-fake-ajax.js b/lib/jasmine-fake-ajax.js
@@ -19,12 +19,12 @@
     } else if (!_.isEmpty(allFakeOptions)) {
       var fakeOptions = findMatchingOptions(realOptions, allFakeOptions)
       if (_.isEmpty(fakeOptions)) {
-        jasmine.FakeAjax.log.warn(messageWithContextInfo("No matching fake ajax options was found", realOptions))
+        jasmine.FakeAjax.log.warn(messageWithContextInfo("No matching fake ajax registration found.", realOptions))
       } else {
         callAvailableCallbackHandlers(realOptions, fakeOptions)
       }
     } else {
-      jasmine.FakeAjax.log.warn(messageWithContextInfo("There are no fake ajax options defined", realOptions))
+      jasmine.FakeAjax.log.warn(messageWithContextInfo("No fake ajax registrations found. Perhaps you forgot to register some using .fakeAjax?", realOptions))
     }
   }
 
@@ -231,7 +231,7 @@
   }
 
   function messageWithContextInfo(message, realOptions) {
-    return message + ", spec: '" + jasmine.getEnv().currentSpec.description + "', real ajax url: '" + realOptions.url + "'."
+    return message + " (spec: '" + jasmine.getEnv().currentSpec.description + "', actual ajax url that was called by application: '" + realOptions.url + "')"
   }
 })(jQuery, jasmine)
 

diff --git a/spec/fake-ajax-spec.js b/spec/fake-ajax-spec.js
@@ -566,17 +566,17 @@ describe('logging', function() {
   describe('without fake ajax options', function() {
     it('logs warning', function() {
       $.get('/example')
-      expect(testLog.latestWarning()).toEqual("There are no fake ajax options defined, spec: " +
-        "'logs warning', real ajax url: '/example'.")
+      expect(testLog.latestWarning()).toEqual("No fake ajax registrations found. Perhaps you forgot to register some using .fakeAjax? (spec: " +
+        "'logs warning', actual ajax url that was called by application: '/example')")
     })
   })
 
   describe('without matching url', function() {
     it('logs warning with real url and spec description', function() {
       fakeAjax({registrations:[{url: '/this'}]})
       $.get('/that', function(){})
-      expect(testLog.latestWarning()).toEqual("No matching fake ajax options was found, spec: " +
-        "'logs warning with real url and spec description', real ajax url: '/that'.")
+      expect(testLog.latestWarning()).toEqual("No matching fake ajax registration found. (spec: " +
+        "'logs warning with real url and spec description', actual ajax url that was called by application: '/that')")
     })
   })