Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concrete return type for MkFieldLens.mkFieldLens #1324

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Concrete return type for MkFieldLens.mkFieldLens #1324

merged 2 commits into from
Sep 7, 2023

Conversation

liorregev
Copy link
Contributor

Fixes #1323

joroKr21
joroKr21 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@joroKr21 joroKr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will have to backport this to series/2.3 branch to actually release

@joroKr21 joroKr21 merged commit 3d81218 into milessabin:main Sep 7, 2023
7 checks passed
joroKr21 added a commit to joroKr21/shapeless that referenced this pull request Apr 25, 2024
@liorregev @joroKr21
Concrete return type for MkFieldLens.mkFieldLens (milessabin#1324)
065bfd3 
Co-authored-by: Lior Regev <lior.regev@placer.ai>
Co-authored-by: Georgi Krastev <joro.kr.21@gmail.com>
@joroKr21 joroKr21 mentioned this pull request Apr 25, 2024
Merged
joroKr21 added a commit that referenced this pull request Apr 26, 2024
@joroKr21 @xuwei-k
@liorregev @DmytroMitin
Backport recently merged PRs (#1353)
d969cd2 
* add explicit type for implicit def (#1330)

* Concrete return type for `MkFieldLens.mkFieldLens` (#1324)

Co-authored-by: Lior Regev <lior.regev@placer.ai>
Co-authored-by: Georgi Krastev <joro.kr.21@gmail.com>

* Add support for `Generic` materialized in companion object of nested case class (#1286)

Co-authored-by: Georgi Krastev <joro.kr.21@gmail.com>

---------

Co-authored-by: kenji yoshida <6b656e6a69@gmail.com>
Co-authored-by: Lior Regev <lioregev@gmail.com>
Co-authored-by: Lior Regev <lior.regev@placer.ai>
Co-authored-by: Dmytro Mitin <DmytroMitin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joroKr21 joroKr21 joroKr21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MkFieldLens.mkFieldLens returns a derived type instead of type parameter
2 participants
@liorregev @joroKr21