Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbt 1.1.1 #813

Merged
merged 1 commit into from Feb 12, 2018
Merged

sbt 1.1.1 #813

merged 1 commit into from Feb 12, 2018

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Feb 11, 2018

No description provided.

@xuwei-k xuwei-k mentioned this pull request Feb 11, 2018
Closed
@codecov-io
Copy link

codecov-io commented Feb 11, 2018 •
edited

Codecov Report

Merging #813 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files          64       64           
  Lines        1499     1499           
  Branches        7        7           
=======================================
  Hits         1319     1319           
  Misses        180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc30064...311617e. Read the comment docs.

larsrh
larsrh reviewed Feb 11, 2018
View reviewed changes
Copy link
Contributor

@larsrh larsrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuwei-k Thanks for bringing this over the finish line.

It appears that you have adapted changes by @SystemFw. As a courtesy, could you please add him to the commit, like so?

build.sbt
@@ -384,7 +383,7 @@ lazy val releaseSettings = Seq(
inquireVersions,
runClean,
runTest,
releaseStepCommand(s"++${Scala211}"),
releaseStepCommand(s"++${Scala211}!"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this exclamation mark good for?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to restore the behaviour of ++ post 1.0.0 to the pre-1.0.0 behavior. I found a mention of it in the 1.0.0 release notes, under "Improvements". The PR which added it, from @jroper, is here sbt/sbt#2613, with some relevant comments by @eed3si9n here sbt/sbt#2613 (comment). I can't find any actual documentation of the ++ changes in general or the ! suffix in particular.

Anyhow, adding it seems like the right thing to do.

@milessabin
Copy link
Owner

LGTM. Many thanks ... merging!

@milessabin milessabin merged commit b141d0c into milessabin:master Feb 12, 2018
@larsrh
Copy link
Contributor

larsrh commented Feb 12, 2018

👏

@SystemFw
Copy link
Contributor

Thanks @xuwei-k for taking this over the finish line!

@xuwei-k xuwei-k deleted the sbt-1 branch February 13, 2018 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milessabin milessabin milessabin left review comments

@larsrh larsrh larsrh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xuwei-k @codecov-io @milessabin @larsrh @SystemFw