Problem upgrading to 1.2.0 #810
Comments
|
Same here. System configuration: related #574 |
|
Same here Rails 4.2.11.1 |
|
I get a stack overflow in Warden when using Wicked_PDF 1.2.0. I use: Locking wicked PDF version to 1.1.0 makes the problem go away and things run normal again. |
|
Same issue SystemStackError: stack level too deep (Most recent call first) on Heroku. Any ideas? |
If you are on Rails you can pin the |
|
Thanks for reporting the issue everyone. I've pushed up a fix in #813 and released a new version If you can provide more info about what other gems might be interfering by stepping into the |
|
Thanks for the update. Unfortunately I still get the stack overflow with version 1.2.1. This happens if I just HTTP GET our login page. Seems gem "remotipart" has something to do with this. |
|
Confirmed. Extra info, ancestor chain:
calls to Remotipart RenderOverrides
|
|
Thanks for the update. I too still get the stack overflow with version 1.2.1. SystemStackError:
stack level too deep
# /xxxxxxxxx/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/wicked_pdf-1.2.1/lib/wicked_pdf/pdf_helper.rb:46:in `call'
# /xxxxxxxxx/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/wicked_pdf-1.2.1/lib/wicked_pdf/pdf_helper.rb:46:in `render_with_wicked_pdf'
# /xxxxxxxxx/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/wicked_pdf-1.2.1/lib/wicked_pdf/pdf_helper.rb:30:in `render'
...
# /xxxxxxxxx/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/remotipart-1.4.2/lib/remotipart/render_overrides.rb:16:in `render_with_remotipart'
# /xxxxxxxxx/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/wicked_pdf-1.2.1/lib/wicked_pdf/pdf_helper.rb:46:in `call'
# /xxxxxxxxx/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/wicked_pdf-1.2.1/lib/wicked_pdf/pdf_helper.rb:46:in `render_with_wicked_pdf'
# /xxxxxxxxx/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/wicked_pdf-1.2.1/lib/wicked_pdf/pdf_helper.rb:30:in `render'
...
# /xxxxxxxxx/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/remotipart-1.4.2/lib/remotipart/render_overrides.rb:16:in `render_with_remotipart'
# /xxxxxxxxx/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/wicked_pdf-1.2.1/lib/wicked_pdf/pdf_helper.rb:46:in `call'
# /xxxxxxxxx/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/wicked_pdf-1.2.1/lib/wicked_pdf/pdf_helper.rb:46:in `render_with_wicked_pdf'
# /xxxxxxxxx/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/wicked_pdf-1.2.1/lib/wicked_pdf/pdf_helper.rb:30:in `render'
# ./app/controllers/xxxxxxx_controller.rb:12:in `create' # => render status: :ok, json: { status: :ok } |
|
@P9GIT Question for you: Were you using WickedPDF 1.1.0 without issue, or did you just start with 1.2.0? The older version still uses Worst case, I think I could release a version where you can opt-in or out of including the render override, and translate |
|
@unixmonkey can you take a look at PR #812 as I think it could solve this issue and cleanup things a bit. |
|
I can also confirm the issue(s) in And we have been using this gem for quiet some time. We faced issues when updating our stack due to security fixes in rails and devise and some other gems. And were hit by this, locking to 1.1.1 (version we were using prior) fixes the issue. Didn't dig deep but it didn't even let our server load home page with: And our tests were failing with stack level too deep issue: Let me know if i can provide any more information to help solve this issue. |
|
We have used 1.1.0 for a long period before the update without a hitch. |
|
Can confirm I've been experiencing the same issue. 1.1.0 works fine, 1.2.0 causes a stack overflow. |
|
On wicked_pdf version 1.2.1 problem reproduces: `fatal - machine stack overflow in critical region: ^C/Users/arsenabalyan/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/web-console-2.3.0/lib/web_console/middleware.rb:18: [BUG] vm_call_cfunc: cfp consistency error (0x000000010f65efa0, 0x000000010f65eaf0) -- Crash Report log information -------------------------------------------- -- Control frame information ----------------------------------------------- -- Ruby level backtrace information ---------------------------------------- -- C level backtrace information ------------------------------------------- -- Other runtime information -----------------------------------------------
|
|
Hi when I use 1.2.1 version (with 1.1.0 gem works), I have this problem: #<Thread:0x00007fcb7933e3b0@puma 001@/Users/aleksandrleontev/.rvm/gems/ruby-2.6.2@mvp/gems/puma-3.12.1/lib/puma/thread_pool.rb:89 run> terminated with exception (report_on_exception is true): Hope it can be solved. |
|
I've just released a new version of wicked_pdf, version It may not help with other gems that work similarly, but I wanted to get a fix out there before working on the core issue, which will likely require a release with some deprecation warnings, and a major version bump. We will be working to provide a better way to hook into Rails' rendering system for |
|
1.2.2 fixed the issue for me |
|
@unixmonkey Yes, for me works, too. Thank you! |
|
Works here also. |
|
Hi @unixmonkey UPDATE: moved to separate issue #845 I fell over a new instance of "stack level too deep" even with the new 1.2.2 version. Funny thing is that this exception only happens in rspec tests of endpoints which performs HTML rendering and not PDF. It seems like an edge case. Reverting to "WickedPDF" version 1.1.0 makes the exception go away. Example of failing endpoint: The above "render" command is the line 258 referred to in the backtrace below. Simplified Rspec code: Exception: ... (this goes on and on)... |
|
This version is out-of-date and this issue has been addressed in newer versions. Closing this, but feel free to open a new issue if you are still having this issue on the latest version. |
|
I am having similar issue with 1.4.0 |
|
I am having exact same issue. with Stack level error on installation without applying any helpers into my codebase. Rails 6.1.4.4 |
|
@stewgloves can you please try installing from the master branch? It has a lot of fixes I’m planning on releasing soon. |
|
@unixmonkey amazing, the master branch fixed the issue for me! |
|
Create a file : config/initializers/wicked_pdf.rb |
After upgrading from 1.1.0 to 1.2.0 all requests to the rails app fail. The system seems to go into an infinite loop when trying to render the page. The log shows
FATAL Rails :
SystemStackError (stack level too deep):
wicked_pdf (1.2.0) lib/wicked_pdf/pdf_helper.rb:30:in
render' wicked_pdf (1.2.0) lib/wicked_pdf/pdf_helper.rb:43:inrender_with_wicked_pdf'... (this goes on and on)...
wicked_pdf (1.2.0) lib/wicked_pdf/pdf_helper.rb:30:in
render' wicked_pdf (1.2.0) lib/wicked_pdf/pdf_helper.rb:43:inrender_with_wicked_pdf'wicked_pdf (1.2.0) lib/wicked_pdf/pdf_helper.rb:30:in
render' wicked_pdf (1.2.0) lib/wicked_pdf/pdf_helper.rb:43:inrender_with_wicked_pdf'wicked_pdf (1.2.0) lib/wicked_pdf/pdf_helper.rb:30:in
render' wicked_pdf (1.2.0) lib/wicked_pdf/pdf_helper.rb:43:inrender_with_wicked_pdf'actionpack (4.2.11.1) lib/action_controller/metal/implicit_render.rb:10:in
default_render' actionpack (4.2.11.1) lib/action_controller/metal/implicit_render.rb:5:insend_action'System configuration:
Ubuntu 18.04
Rails 4.2.11.1
Ruby 2.4.5
The text was updated successfully, but these errors were encountered: