Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile on current rust git #83

Closed
ids1024 opened this issue Aug 21, 2015 · 2 comments
Closed

Does not compile on current rust git #83

ids1024 opened this issue Aug 21, 2015 · 2 comments

Comments

@ids1024
Copy link

ids1024 commented Aug 21, 2015

Compilation fails due to the api change in commit
rust-lang/rust@dfa4bca.

The solution is to change lines like let weak = src.downgrade(); to let weak = Arc::downgrade(&src);.

This should probably be changed when the next rust nightly is released. Or if possible it would be good to support both versions of rust, but I don't know rust well enough to know if that is possible.

@milibopp
Copy link
Owner

Thank you for letting me know!

I think the latter version should have worked before as well, since src.downgrade() is only sugar for Arc::downgrade(&src).

@milibopp
Copy link
Owner

note: when stabilized, this finally also takes care of #47.

milibopp pushed a commit that referenced this issue Aug 23, 2015
milibopp pushed a commit that referenced this issue Aug 23, 2015
milibopp pushed a commit that referenced this issue Aug 23, 2015
Fixes #83.

Also gets rid of deprecated scoped threads.
milibopp added a commit that referenced this issue Jun 10, 2023
Fixes #83.

Also gets rid of deprecated scoped threads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants