Skip to content

Commit

Permalink
ALSA: hda/realtek - Apply the coef-setup only to ALC269VB
Browse files Browse the repository at this point in the history
The coef setup in alc269_fill_coef() was designed only for ALC269VB
model, and this has some bad effects for other ALC269 variants, such
as turning off the external mic input.  Apply it only to ALC269VB.

Signed-off-by: Kailang Yang <kailang@realtek.com>
Cc: <stable@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
kailangyang authored and tiwai committed Mar 7, 2012
1 parent 8f23921 commit 526af6e
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions sound/pci/hda/patch_realtek.c
Expand Up @@ -2068,12 +2068,16 @@ static int alc_build_controls(struct hda_codec *codec)
*/

static void alc_init_special_input_src(struct hda_codec *codec);
static int alc269_fill_coef(struct hda_codec *codec);

static int alc_init(struct hda_codec *codec)
{
struct alc_spec *spec = codec->spec;
unsigned int i;

if (codec->vendor_id == 0x10ec0269)
alc269_fill_coef(codec);

alc_fix_pll(codec);
alc_auto_init_amp(codec, spec->init_amp);

Expand Down Expand Up @@ -5476,8 +5480,12 @@ static const struct alc_model_fixup alc269_fixup_models[] = {

static int alc269_fill_coef(struct hda_codec *codec)
{
struct alc_spec *spec = codec->spec;
int val;

if (spec->codec_variant != ALC269_TYPE_ALC269VB)
return 0;

if ((alc_get_coef0(codec) & 0x00ff) < 0x015) {
alc_write_coef_idx(codec, 0xf, 0x960b);
alc_write_coef_idx(codec, 0xe, 0x8817);
Expand Down

0 comments on commit 526af6e

Please sign in to comment.