Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition and small fix #3

Merged
merged 5 commits into from
Apr 11, 2020
Merged

Conversation

eevan78
Copy link
Contributor

@eevan78 eevan78 commented Apr 10, 2020

Hi Miljan!
I have found some errors in links on README.md and I have contributed two more commands to git!

Great project!

Links for CONTRIBUTING.md, contributors and UNLICENSE didn't work, I pointed them to **develop** branch.
This one adds command to list local commits that aren't pushed yet and list upstream commits that aren't pulled yet.
Copy link
Owner

@miljanuscumlic miljanuscumlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ivan,
Thanks for your contribution. This is looking good, but there is one small issue that should be addressed before I merge it. I left a comment.

README.md Outdated Show resolved Hide resolved
As agreed, I'm changing the branch in several links to `master`
Missing `the` in several places
Consider these changes to the wording.
Copy link
Owner

@miljanuscumlic miljanuscumlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants