New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change info about touchscreen #6
Conversation
This adds a lot of details I am on the European version, NixOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. There is one open question in my comments.
re-haul wording
README.md
Outdated
@@ -46,15 +46,15 @@ Tested disctributions, kernel versions: | |||
| Ports | 3 × USB-C, Mini-jack | ✔ Yes | All the ports work. Charging works only via left port. | | |||
| Graphic Dongle | USB-Typ-C to USB-Typ-A-/HDMI-/VGA | ✔ Yes | Works. HDMI monitor works, USB keyboard works. | | |||
| Keyboard | | ⚠️ Minor issues | see [Keyboard details](#keyboard) below | | |||
| Touchpad | | ✔ Yes | Touchpad is detected and works good in GNOME. Left, right clicks, 2-finger scrolling, 2-finger zooming, 3-finger workspaces switching work. | | |||
| Touchpad | | ✔ Yes | Touchpad is an optional purchase. It works as intended and is fully functional. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is about touchpad, not the touchscreen. You could add the comment about the "optional purchase" to the "Display " section https://github.com/milkovsky/Linux-on-Lenovo-Slim-7-Carbon-AMD#touchscreen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh god, how could I oversee that. Thanks for the heads up shame :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering there are multiple ways to drive a touchscreen, can you confirm which way you use?
That differs from distro to distro.
https://wiki.archlinux.org/title/Touchscreen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries :)
I did not have to do any extra steps to setup touchscreen. It worked out-of-the-box for Ubuntu, PopOs, Fedora in my tests.
Add details, small improvements on grammar and typos
Add link, correct typo
@ShalokShalom thanks a lot! merged |
@ShalokShalom There is one important open issue about speakers here. |
@milkovsky Yeah, I was already looking at it. I ran into an issue with the software that is supposed to reasign the pins. |
This adds a lot of details
I am on the European version, NixOS