Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for occasional crash due to unsupported URI schemes #112

Merged
merged 2 commits into from Jun 8, 2016

Conversation

AndrewGretton
Copy link

We have recently begun using Premailer in a high traffic environment (and we love it). We've run into a handful of users who have inadvertently injected client-side CSS links, and currently Premailer throws an exception when it tries to inline it. That's because underneath, it uses WebClient, which only supports four URI schemes.

Here's a suggested fix which only attempts to download from the four supported schemes, including a supporting test. Would love any feedback! Thanks.

@martinnormark martinnormark merged commit dfa7469 into milkshakesoftware:master Jun 8, 2016
@martinnormark
Copy link
Contributor

Thanks for this 🙇

@AndrewGretton
Copy link
Author

@martinnormark any chance of pushing this (and any other fixes) to Nuget? Would love to get them included. Thanks!

@martinnormark
Copy link
Contributor

@AndrewGretton New release is cooking 🍤

Build: https://ci.appveyor.com/project/milkshakesoftware/premailer-net/build/164

Should push to Nu Get in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants