WIP: PreMailer.Net 2 #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved to managing dependencies with NuGet instead of library references. - Changed namespacing so the compiler can differentiate between the root namespace and the PreMailer class. - Made the PreMailer class and it's only method static so it no longer needs an instance to be called. - Wrapped the style replacement loop in a Try/Catch so that Fizzler choking on an unsupported CSS attribute does not prevent the merge from completing. Bumped the version to 2.0
Merge pull request, closes #11 Update copyright year, in GlobalAssemblyInfo.cs
Remove bloat
Enable package restore. Remove unnecessary dependencies.
Manage dependencies. Set version to 2.0.0-alpha. Add release notes.
Redesign CssParser to support CSS Specificity. Define and parse selector type.
|
What happened to premailer 2.0? |
|
@blowsie I killed it since some of it got implemented by @robcthegeek and the direction of his implementation were more solid than what was in 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this pull request early, to track features and progress for PreMailer.Net 2.
Complete re-write to support external styles, honor CSS specificity, and add more pre-mailing features as supported by the "original" ruby gem.
New features
<link>elements add support for inlining css specified as <link> elements #8Additional pre-mailing features #5
href,srcand CSSurl('')Bugs