Add optional custom markupformatter parameter #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR 🙏 Release is cut, and will hit nuget fairly soon |
|
@CaptainStack do you have example code on how to use the override to prevent encoding '&' in the querystring (#193)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All I've done in this change is add an optional parameter for a custom IMarkupFormatter that can be supplied to PreMailer.Net for special circumstances where the provided MarkupFormatters are not working for the client's needs.
The issue was caused by the default behavior used in AngleSharp, which provides an interface for custom formatters in case that behavior does not work. This change simply exposes that interface as an option in PreMailer.Net and passes it onto AngleSharp.
I implemented this specifically to address the problem I was having in this issue:
#193
I also collaborated with @FlorianRappl - the primary author of AngleSharp to reach this implementation. Please let me know if you have any questions or concerns about this feature :)