Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests and fix for image dimensions issue. This closes #51. #52

Conversation

colefichter
Copy link
Contributor

This should close #51 and includes tests for images both with and without a style block.

@colefichter
Copy link
Contributor Author

@martinnormark Is it possible to get this included and have a NuGet package published? We'd love to continue using your official NuGet build, but if that's not cool we'll fork and switch over to that.
Thanks!

@martinnormark
Copy link
Contributor

@colefichter Yes, sure. I will merge and publish later today.

martinnormark added a commit that referenced this pull request Nov 19, 2014
Added tests and fix for image dimensions issue. This closes #51.
@martinnormark martinnormark merged commit bc30943 into milkshakesoftware:master Nov 19, 2014
@martinnormark
Copy link
Contributor

@colefichter The new package has been pushed https://www.nuget.org/packages/PreMailer.Net/

@colefichter
Copy link
Contributor Author

@martinnormark Thanks so much! We really appreciate you including this.

🏆

@martinnormark
Copy link
Contributor

@colefichter Thanks for requesting and implementing the changes! 🍺 Happy to merge and publish improvements from the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image dimensions do not conform to HTML spec.
2 participants