-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PackageListCtrl): Swap ng-repeat for ng-grid #1330
Conversation
Improves render performance of the package list on the website. CSS changes are not addressed in this commit. Jquery and and ng-grid have been added as client-side dependencies. Angularjs needed to be upgraded from 1.2.0-rc2 to 1.2.0 Fixes to #1326
Playing with this now - thanks! It's certainly much faster. The fixed height and scrolling within the table is less convenient, though, so I'm just taking a bit of time to understand the trade-offs and alternatives, such as re-integrating datatables. |
@nicwins is there anyway to make this non-fixed height? |
@milkypostman I think the whole point is that this only renders a limited-height list, for speed, but I may be mistaken. |
hrm, I just got a chance to try this out and it's cool but is a bummer having two independent scrolling mechanisms. |
What if we were to make the package list its own page and have it be fixed height of the browser window. as it stands I do kinda find the current way to be a bit cumbersome. Like, it you only have a few results you scroll to the top of the page automatically. just an idea; not like I have so much free time I can just whip it up! |
re: no-fixed-height @purcell is right, there's no way (that I know of) to turn off fixed height and get good performance. re: 100% page height: thats what I've always done when using ng-grid on my projects. It works well -- I can put together a version doing that this weekend. There's couple of options:
I'm just throwing option 1 out there because its kind of nice to land on the page and just start searching. |
this would be excellent. i don't really use the package list all that much and my guess is that So my vote is for having the home page be the description and twitter feed it's kinda purcell's baby so he can have final say. On Thu, Jan 9, 2014 at 10:13 PM, nicwins notifications@github.com wrote:
|
Closing because we've switched away from Angular. Thanks again, though. :-) |
Improves render performance of the package list on the website. CSS
changes are not addressed in this commit. Jquery and and ng-grid have
been added as client-side dependencies. Angularjs upgraded
from 1.2.0-rc2 to 1.2.0
Fixes to #1326