Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jar-manifest-mode #2631

Merged
merged 1 commit into from
Mar 29, 2015
Merged

Add jar-manifest-mode #2631

merged 1 commit into from
Mar 29, 2015

Conversation

omajid
Copy link
Contributor

@omajid omajid commented Mar 28, 2015

Add jar-manifest-mode that implements a major mode for editing Manifest.mf files used in JARs.

@purcell
Copy link
Member

purcell commented Mar 28, 2015

Thanks. Quick feedback:

  • For setq-local you need Emacs 24.3 or greater. Rather than declaring a dependency on that Emacs version, I suggest you use the classic (set (make-local-variable 'name) value) method instead
  • prog-mode is only available in Emacs 24, so you should add a ;; Package-Requires: ((emacs "24")), or use a workaround like in haml-mode.

Looks good otherwise. :-)

@omajid
Copy link
Contributor Author

omajid commented Mar 28, 2015

Thanks for the feedback! Any suggestion on how to identify these compatibility issues beforehand?

Fixed with this commit.

@purcell
Copy link
Member

purcell commented Mar 29, 2015

Any suggestion on how to identify these compatibility issues beforehand?

I hope to add some corresponding checks to flycheck-package when time allows.

purcell added a commit that referenced this pull request Mar 29, 2015
@purcell purcell merged commit ed68a91 into melpa:master Mar 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants