Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evil-rsi, a port of vim-rsi #2637

Merged
merged 1 commit into from
Mar 31, 2015
Merged

Add evil-rsi, a port of vim-rsi #2637

merged 1 commit into from
Mar 31, 2015

Conversation

linktohack
Copy link
Contributor

It brings some essential emacs motion bindings (and potentially [RSI]...) back.

It brings some essential `emacs` motion bindings (and potentially [RSI]...) back.
@purcell
Copy link
Member

purcell commented Mar 31, 2015

  • The line (when (auto-complete-mode) ...) will actually enable auto-complete-mode. :-)
  • In any case you're testing for auto-complete-mode at the wrong time: you're testing it while defining the minor mode, not while trying to enable it. What you probably want is just to make the keymap a top-level variable, then use an (eval-after-load 'auto-complete ...) block to add those bindings.
  • I'm not sure you should be setting the global value of ac-use-menu-map for the user. Ideally you wouldn't modify it at all.

@linktohack
Copy link
Contributor Author

Ok, thanks for your advices. Updated.

@purcell
Copy link
Member

purcell commented Mar 31, 2015

Thanks. Just pending linktohack/evil-rsi#2 now.

purcell added a commit that referenced this pull request Mar 31, 2015
@purcell purcell merged commit 24f438b into melpa:master Mar 31, 2015
@purcell
Copy link
Member

purcell commented Mar 31, 2015

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants