-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add speech-tagger recipe #3053
add speech-tagger recipe #3053
Conversation
speech-tagger is an extension to tag parts of speech in an emacs buffer using stanford coreNLP. It can be found at https://github.com/cosmicexplorer/speech-tagger. I am the maintainer of this package.
Thanks, looks good. I'd strongly encourage you to follow the elisp coding conventions for symbol naming, though, because the clojure-style naming here is not at all idiomatic. Additionally, triple-semicolon comments have a specific meaning, so only use them for standard section headings, e.g. Hope that helps, -Steve |
Fixed the clojure naming and kept triple-semicolon lines to bookends only. Thanks for the link to those conventions. I've also made a change (which you can see in this pull request) to the packaging; instead of downloading the jar at runtime, it pulls it in as part of the package, which hopefully takes fewer people by surprise. |
Just fixed an issue where the "loading" overlay wasn't being removed by the clear-tags function, and made the jar path a |
Sorry for the slow feedback. The |
Alright, that's what I had before. I'm not familiar with |
Ok, it's proving harder than I thought to download a file over http; |
Ok, turned out the coding system was the problem; specifying |
Cool, thanks - merged. :-) |
speech-tagger is an extension to tag parts of speech in an emacs buffer
using stanford coreNLP. It can be found at
https://github.com/cosmicexplorer/speech-tagger. I am the maintainer of
this package.