Malformed URL and encoding of percentage #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… internal calls did not encode values passed to it. This fixes the '%' encoding, and the resulting Malformed URL exception.
|
I decided to implement it in a different way and also to add a test to make sure it won't break IE8 while running the file locally. Thanks for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_registerChangeexpects thenewHashparameter to be encoded, but some internal calls did not encode values passed to it. This fixes the '%' encoding, and the resulting Malformed URL exception.The fix has been tested in IE8, IE9, latest Firefox and Chrome. I've added a unit test that tests for this case. Before this patch the unit test fails, and when applied it succeeds.