Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any method that access internal properties from the SignalBinding throws errors after calling SingalBinding.detach() #25

Closed
millermedeiros opened this issue Jun 14, 2011 · 0 comments

Comments

@millermedeiros
Copy link
Owner

as of v0.6.2 the second time you call detach on a binding it throws an error since the binding doesn't have the _signal and _listener properties anymore. I think the proper behavior would be to simply return null instead of throwing an error.. (detach() usually returns the listener)

I think it doesn't make any sense for a binding exist without a listener/signal but throwing errors like this ain't fun or necessary.. (specially if calling detach multiple times..)

maybe add a new method like isBound() that checks if Binding still references a Signal..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant