252 remove engines from package.json #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@westtrade @davidroeca please, can you review this pull request |
cjpatoilo
changed the title
|
👍 looks good to me! |
|
Is it possible to release a new version with the fix of node engine? |
|
@GreatWizard I will prepare the new version ASAP #254 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request should close the issue #252
Description
Consumers of the npm package just get the dist files so they aren't affected by this AFAICT. What Milligram uses to build and develop itself does shouldn't affect consumers. So having a Node.js version could be considered wrong.
This will allow Milligram to use whatever Node.js version we want to use without having to support unsupported Node.js versions anymore.
Maybe in the future make sense Milligram to use only the up to date versions of the Node.js (>=lts) but for now, the
enginesproperty should be removed from package.jsonHightlight
enginesproperty from package.json (8c80c8f)