Fatal error: Class 'Login' not found

[TheZoker]

Awesome framework!

But I have a issue:
When I try to use Login::getToken() I get the error

Fatal error: Class 'Login' not found in /helper.php on line 42

But I included the class in the helper.php file:

<?php
require_once( 'framework/github-api.php' );
use Milo\Github;

[JanTvrdik]

You need to use namespace, i.e. Milo\Github\OAuth\Login.

[TheZoker]

Ah ok works :) Thank you!
I now get something like this on var_dump:

And when i simple return the token, I don`t get any output.

How can I get the token out of this?

[JanTvrdik]

You need to load github-api.php (or setup autoloading) before calling session_start.

[TheZoker]

Yep I`m doing that, otherwise I would not get this response I guess.

[JanTvrdik]

No, __PHP_Incomplete_Class means that at the time of session_start the class Milo\Github\OAuth\Token is undefined.

[TheZoker]

This is my code
Without the github-api.php I would not be able to use Milo\Github\OAuth\ and these stuff, right?

[JanTvrdik]

Strange. Do you have error_reporting set to E_ALL and enabled display_errors?

[milo]

@TheZoker Try to dump the $_SESSION content. Isn't there some garbage? If so, clean it somehow.

The library uses $_SESSION['milo.github-api']. Isn't touched by another app?

[TheZoker]

This is the dump of $_SESSION

I use it to build a wordpress plugin, so it should be untouched

[milo]

Try unset($_SESSION['milo.github-api']) directly after the session_start(). Only once and remove it. Then, try whole auth roundtrip again.

[milo]

Oh, maybe I got it. Isn't session started somewhere earlier? I mean, your session_start() in oauth() function is the second call.

[TheZoker]

But I dont have any other session_start() anywhere else

[milo]

Wordpress does not start it? Or maybe PHP's session.auto_start? Try var_dump(session_status()); before the require_once ...;

[TheZoker]

So there is another plugin uses the session

Btw: How can I open the oauth window in a new window (popup)?

[milo]

I see. So, session is somewhere already started before you load the github-api libs. I don't know the Wordpress, maybe there is some hook for plugins to load the libraries first.

If not, you can try this nasty hack in here and let me know.

public function getToken()
{
    $token = $this->storage->get('auth.token');
    if ($token === NULL) {
        throw new Github\LogicException('Token has not been obtained yet.');
    } elseif ($token instanceof \__PHP_Incomplete_Class) {
        $token = unserialize(serialize($token));
    } 
    return $token;
}

[milo]

Btw: How can I open the oauth window in a new window (popup)?

Sorry, that's the frontend thing which I don't solve.

[TheZoker]

I can`t test it, because I get this error:

https://github.com/TheZoker/GithubTemp/blob/master/helper.php#L16
https://github.com/TheZoker/GithubTemp/blob/master/ajax.php
https://github.com/TheZoker/GithubTemp/blob/master/assets/script.js

Thank you very much for your help!

[milo]

@TheZoker The error is caused by the Same Origin Policy setting. It is not relevant to this library.

Anyway, I released a new version 1.4.3 where is a token in session stored as an ordinary array. It prevents __PHP_Incomplete_Class error.

[TheZoker]

@milo Is there any way to generate and save a state without calling askPermissions() ?

[milo]

No, if you need a user's permissions. Btw. why do you access GitHub webpage by AJAX? You need to redirect a browser window. User will click 'Accept' on GitHub web and than will be redirected back to your site.