Support for <let> and document() in XPath selectors, PHP 8.2 deprecation fixes, and GitHub Actions integration #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your great work on milo/schematron. As the maintainer of youniwemi/digital-invoice, I needed a lightweight library for schematron validation. Your library nearly met my needs perfectly, but I found that support for and the document() function in xpath selectors was lacking.
To address this, I added these features and updated the test cases. Additionally, I included fixes for some PHP 8.2 deprecations and set up a GitHub action to test across PHP versions 8.0 to 8.3 (that's why I had to update nette/tester version).
I welcome any feedback on this PR. Thank you for considering those changes.
Best regards,
rahal