We don't need to dup key, since only value is weak.

miloops · Nov 19, 2010 · a84add0 · a84add0
1 parent 7d563f9
commit a84add0
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/activesupport/lib/active_support/weak_hash.rb b/activesupport/lib/active_support/weak_hash.rb
@@ -22,16 +22,9 @@ def [](key)
       end
 
       def []=(key, value)
-        key2 = case key
-               when Fixnum, Symbol, true, false, nil
-                 key
-               else
-                 key.dup
-               end
-
-        @rev_cache[value.object_id][key2] = true
-        @cache[key2] = value.object_id
-        @key_map[key.object_id] = key2
+        @rev_cache[value.object_id][key] = true
+        @cache[key] = value.object_id
+        @key_map[key.object_id] = key
 
         ObjectSpace.define_finalizer(value, @reclaim_value)
       end