-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CP 1.0.x] Add remove leaked collection meta cmd (#223)
Cherry-pick from main #222 /kind improvement Signed-off-by: xige-16 <xi.ge@zilliz.com>
- Loading branch information
xige-16
committed
Dec 1, 2023
1 parent
7c2b8ec
commit 36d674d
Showing
4 changed files
with
164 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| package remove | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "path" | ||
| "strconv" | ||
| "strings" | ||
|
|
||
| "github.com/samber/lo" | ||
| "github.com/spf13/cobra" | ||
| clientv3 "go.etcd.io/etcd/client/v3" | ||
|
|
||
| "github.com/milvus-io/birdwatcher/models" | ||
| "github.com/milvus-io/birdwatcher/states/etcd/common" | ||
| etcdversion "github.com/milvus-io/birdwatcher/states/etcd/version" | ||
| ) | ||
|
|
||
| var paginationSize = 2000 | ||
|
|
||
| type ExcludePrefixOptions func(string) bool | ||
|
|
||
| // CollectionCleanCommand returns command to remove | ||
| func CollectionCleanCommand(cli clientv3.KV, basePath string) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "collection-meta-leaked", | ||
| Short: "Remove leaked collection meta for collection has been dropped", | ||
| Run: func(cmd *cobra.Command, args []string) { | ||
| run, err := cmd.Flags().GetBool("run") | ||
| if err != nil { | ||
| fmt.Println(err.Error()) | ||
| return | ||
| } | ||
|
|
||
| collections, err := common.ListCollectionsVersion(context.TODO(), cli, basePath, etcdversion.GetVersion()) | ||
| if err != nil { | ||
| fmt.Println(err.Error()) | ||
| return | ||
| } | ||
|
|
||
| id2Collection := lo.SliceToMap(collections, func(col *models.Collection) (string, *models.Collection) { | ||
| fmt.Printf("existing collectionID %v\n", col.ID) | ||
| return strconv.FormatInt(col.ID, 10), col | ||
| }) | ||
|
|
||
| cleanMetaFn := func(ctx context.Context, prefix string, opts ...ExcludePrefixOptions) error { | ||
| return walkWithPrefix(ctx, cli, prefix, paginationSize, func(k []byte, v []byte) error { | ||
| sKey := string(k) | ||
| for _, opt := range opts { | ||
| if opt(sKey) { | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| key := sKey[len(prefix):] | ||
| ss := strings.Split(key, "/") | ||
| collectionExist := false | ||
| for _, s := range ss { | ||
| if _, ok := id2Collection[s]; ok { | ||
| collectionExist = true | ||
| } | ||
| } | ||
|
|
||
| if !collectionExist { | ||
| fmt.Println("clean meta key ", sKey) | ||
| if run { | ||
| _, err = cli.Delete(ctx, sKey) | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| }) | ||
| } | ||
|
|
||
| // remove collection meta | ||
| // meta before database | ||
| collectionMetaPrefix := path.Join(basePath, common.CollectionMetaPrefix) | ||
| // with database | ||
| dbCollectionMetaPrefix := path.Join(basePath, common.DBCollectionMetaPrefix) | ||
| // remove collection field meta | ||
| fieldsPrefix := path.Join(basePath, common.FieldMetaPrefix) | ||
| fieldsSnapShotPrefix := path.Join(basePath, common.SnapshotPrefix, common.FieldMetaPrefix) | ||
| // remove collection partition meta | ||
| partitionsPrefix := path.Join(basePath, common.PartitionPrefix) | ||
| partitionsSnapShotPrefix := path.Join(basePath, common.SnapshotPrefix, common.PartitionPrefix) | ||
| prefixes := []string{ | ||
| collectionMetaPrefix, | ||
| dbCollectionMetaPrefix, | ||
| fieldsPrefix, | ||
| fieldsSnapShotPrefix, | ||
| partitionsPrefix, | ||
| partitionsSnapShotPrefix} | ||
|
|
||
| for _, prefix := range prefixes { | ||
| fmt.Printf("start cleaning leaked collection meta, prefix: %s\n", prefix) | ||
| err = cleanMetaFn(context.TODO(), prefix) | ||
| if err != nil { | ||
| fmt.Println(err.Error()) | ||
| return | ||
| } | ||
| fmt.Printf("clean leaked collection meta done, prefix: %s\n", prefix) | ||
| } | ||
|
|
||
| // remove segment meta | ||
| segmentPrefix := path.Join(basePath, common.SegmentMetaPrefix) | ||
| segmentStatsPrefix := path.Join(basePath, common.SegmentStatsMetaPrefix) | ||
| fmt.Printf("start cleaning leaked segment meta, prefix: %s, exclude prefix%s\n", segmentPrefix, segmentStatsPrefix) | ||
| err = cleanMetaFn(context.TODO(), segmentPrefix, func(key string) bool { | ||
| return strings.HasPrefix(key, segmentStatsPrefix) | ||
| }) | ||
| if err != nil { | ||
| fmt.Println(err.Error()) | ||
| return | ||
| } | ||
|
|
||
| fmt.Printf("clean leaked segment meta done, prefix: %s\n", segmentPrefix) | ||
| }, | ||
| } | ||
|
|
||
| cmd.Flags().Bool("run", false, "flags indicating whether to execute removed command") | ||
| return cmd | ||
| } | ||
|
|
||
| func walkWithPrefix(ctx context.Context, cli clientv3.KV, prefix string, paginationSize int, fn func([]byte, []byte) error) error { | ||
| batch := int64(paginationSize) | ||
| opts := []clientv3.OpOption{ | ||
| clientv3.WithSort(clientv3.SortByKey, clientv3.SortAscend), | ||
| clientv3.WithLimit(batch), | ||
| clientv3.WithRange(clientv3.GetPrefixRangeEnd(prefix)), | ||
| } | ||
|
|
||
| key := prefix | ||
| for { | ||
| resp, err := cli.Get(ctx, key, opts...) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| for _, kv := range resp.Kvs { | ||
| if err = fn(kv.Key, kv.Value); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| if !resp.More { | ||
| break | ||
| } | ||
| // move to next key | ||
| key = string(append(resp.Kvs[len(resp.Kvs)-1].Key, 0)) | ||
| } | ||
|
|
||
| return nil | ||
| } |