Add more unittest to improve coverage #955

cydrain · 2023-06-25T10:18:40Z

Issue: #960

Before:

Overall coverage rate:
  lines......: 59.0% (1209 of 2048 lines)
  functions..: 62.0% (168 of 271 functions)

After:

Overall coverage rate:
  lines......: 70.7% (1871 of 2646 lines)
  functions..: 52.7% (330 of 626 functions)

sre-ci-robot · 2023-06-25T10:18:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mergify · 2023-06-25T10:19:15Z

@cydrain Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

cydrain · 2023-06-26T06:22:07Z

/kind improvement

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>

PwzXxm · 2023-06-26T07:30:21Z

/lgtm

sre-ci-robot requested review from foxspy and liliu-z June 25, 2023 10:18

sre-ci-robot added approved size/L labels Jun 25, 2023

mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-issue labels Jun 25, 2023

mergify bot added the ci-passed label Jun 25, 2023

cydrain force-pushed the caiyd_improve_codecov branch from ce8a24a to 211b909 Compare June 26, 2023 03:55

sre-ci-robot added the kind/improvement label Jun 26, 2023

mergify bot removed the do-not-merge/missing-related-issue label Jun 26, 2023

Add more unittest to improve coverage

dec6900

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>

cydrain force-pushed the caiyd_improve_codecov branch from 211b909 to dec6900 Compare June 26, 2023 06:27

sre-ci-robot assigned PwzXxm Jun 26, 2023

sre-ci-robot added the lgtm label Jun 26, 2023

sre-ci-robot merged commit c561f20 into milvus-io:main Jun 26, 2023
10 of 11 checks passed

cydrain deleted the caiyd_improve_codecov branch June 26, 2023 07:38

Provide feedback