Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Support ordered rolling for v2.3+ #272

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Support ordered rolling for v2.3+ #272

merged 1 commit into from
Aug 14, 2023

Conversation

haorenfsa
Copy link
Contributor

Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #272 (1a44e80) into main (8b221bf) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   79.94%   80.05%   +0.10%     
==========================================
  Files          46       46              
  Lines        4682     4707      +25     
==========================================
+ Hits         3743     3768      +25     
  Misses        795      795              
  Partials      144      144              
Files Changed Coverage Δ
apis/milvus.io/v1beta1/milvus_types.go 74.07% <100.00%> (+1.79%) ⬆️
pkg/controllers/components.go 89.23% <100.00%> (+0.21%) ⬆️
pkg/controllers/dependency_graph.go 100.00% <100.00%> (ø)
pkg/provisioner/cert_manager.go 76.86% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mintcckey
Copy link
Contributor

/lgtm

Copy link

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, LoveEachDay, mintcckey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LoveEachDay,haorenfsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit daa1cbf into milvus-io:main Aug 14, 2023
13 checks passed
@haorenfsa haorenfsa deleted the rolling-2.3 branch August 14, 2023 07:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants