Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against Milvus 2.4 #72

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Test against Milvus 2.4 #72

merged 1 commit into from
Mar 29, 2024
+15 −6

Conversation

roji
Copy link
Collaborator

@roji roji commented Mar 28, 2024

No description provided.

@roji roji changed the title Test on both 2.3.10 and 2.4.o-rc.1 in CI Test on both 2.3.10 and 2.4.0-rc.1 in CI Mar 28, 2024
@roji
Test against Milvus 2.4
9a5e19a 
* Implement CI matrix testing to test on both 2.3.10
  and 2.4.0-rc.1.
@roji roji changed the title Test on both 2.3.10 and 2.4.0-rc.1 in CI Test against Milvus 2.4 Mar 28, 2024
@roji roji marked this pull request as ready for review March 28, 2024 13:26
@roji roji requested a review from weianweigan March 28, 2024 13:26
@roji
Copy link
Collaborator Author

roji commented Mar 28, 2024

Note: after this is merged, main will represent the 2.4 version of the SDK. I'll create a release/2.3 branch so that we can continue improving the 2.3 SDK as necessary, e.g. to release 2.3.1.

@roji roji mentioned this pull request Mar 28, 2024
Open
@roji roji added this to the 2.4.0 milestone Mar 28, 2024
@roji roji self-assigned this Mar 28, 2024
@roji roji added the enhancement New feature or request label Mar 28, 2024
roji
roji commented Mar 28, 2024
View reviewed changes
Milvus.Client.Tests/CollectionTests.cs
Assert.NotEqual(0, compactionId);
if ((await Client.GetVersionAsync()).StartsWith("v2.4.", StringComparison.Ordinal))
{
// Milvus 2.4 returns -1 here as the compaction ID
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yhmo @weianweigan FYI, this is the only case where a test failed when transitioning from 2.3.10 to 2.4.0-rc.1 - not sure if this is intentional...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to contact @yhmo .

@roji roji merged commit a6e62e0 into milvus-io:main Mar 29, 2024
2 checks passed
@roji roji deleted the v2.4.0 branch March 29, 2024 05:15
@roji
Copy link
Collaborator Author

roji commented Mar 29, 2024 •
edited
Loading

Note that I've pushed branch release/2.3 for any work that would happen for 2.3 (with main now representing 2.4).

@yhmo
Copy link
Collaborator

yhmo commented Mar 29, 2024

A bug of compaction is fixed in milvus v2.4.0: milvus-io/milvus#29943
According to the issue description. The old version behavior is: CompactionPlanCount is never set, but CompactionID is set a value regardless of whether a plan is generated or not. This makes it difficult for users to determine whether a compaction plan has been generated.

In v2.4.0, the ManualCompaction() interface has been changed: CompactionPlanCount should be set to the count of the generated compaction plan and CompactionID should be set to a negative value if there's no plan generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weianweigan weianweigan weianweigan approved these changes

Assignees

@roji roji

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roji @yhmo @weianweigan