Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 218 #221

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix issue 218 #221

merged 1 commit into from
Aug 8, 2023

Conversation

nameczz
Copy link
Collaborator

@nameczz nameczz commented Aug 8, 2023

fix #218

Signed-off-by: nameczz <zizhao.chen@zilliz.com>
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #221 (f095318) into main (df556b9) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f095318 differs from pull request most recent head d96b9ec. Consider uploading reports for the commit d96b9ec to get more accurate results

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          32       32           
  Lines        1597     1597           
  Branches      415      416    +1     
=======================================
  Hits         1537     1537           
  Misses         53       53           
  Partials        7        7           
Files Changed Coverage Δ
milvus/const/ErrorReason.ts 100.00% <ø> (ø)
milvus/utils/Format.ts 98.71% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nameczz, shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shanghaikid shanghaikid merged commit c8feab0 into main Aug 8, 2023
2 of 3 checks passed
@shanghaikid shanghaikid deleted the issue-218 branch August 8, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of error handling on invalid collection names
3 participants