Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make proto file path configurable #237

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

shanghaikid
Copy link
Contributor

related to #170

Signed-off-by: ruiyi.jiang <ruiyi.jiang@zilliz.com>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #237 (21c0a6e) into main (d6932f7) will decrease coverage by 0.18%.
Report is 1 commits behind head on main.
The diff coverage is 66.66%.

❗ Current head 21c0a6e differs from pull request most recent head b043bfb. Consider uploading reports for the commit b043bfb to get more accurate results

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   95.93%   95.75%   -0.18%     
==========================================
  Files          32       32              
  Lines        1622     1626       +4     
  Branches      423      426       +3     
==========================================
+ Hits         1556     1557       +1     
- Misses         63       66       +3     
  Partials        3        3              
Files Changed Coverage Δ
milvus/grpc/GrpcClient.ts 70.66% <ø> (ø)
milvus/grpc/BaseClient.ts 76.36% <66.66%> (-4.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nameczz, shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: ruiyi.jiang <ruiyi.jiang@zilliz.com>
@shanghaikid shanghaikid merged commit 62bbdfc into main Aug 25, 2023
2 checks passed
@shanghaikid shanghaikid deleted the makeProtoPathConfigable branch August 25, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants