Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support alter collection #248

Merged
merged 1 commit into from
Oct 10, 2023
Merged

support alter collection #248

merged 1 commit into from
Oct 10, 2023

Conversation

shanghaikid
Copy link
Contributor

this pr add an alterCollecition function.
fix #241

Signed-off-by: ruiyi.jiang <ruiyi.jiang@zilliz.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nameczz, shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #248 (a330217) into main (aae9936) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a330217 differs from pull request most recent head 93c8bc2. Consider uploading reports for the commit 93c8bc2 to get more accurate results

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   95.71%   95.72%   +0.01%     
==========================================
  Files          33       33              
  Lines        1656     1661       +5     
  Branches      406      407       +1     
==========================================
+ Hits         1585     1590       +5     
  Misses         68       68              
  Partials        3        3              
Files Coverage Δ
milvus/grpc/Collection.ts 98.82% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shanghaikid shanghaikid merged commit e957c65 into main Oct 10, 2023
2 of 3 checks passed
@shanghaikid shanghaikid deleted the alterColleciton branch October 10, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support missing AlterCollection
3 participants