Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw more errors if create collection failed with high level api #289

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

shanghaikid
Copy link
Contributor

No description provided.

Signed-off-by: ryjiang <jiangruiyi@gmail.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.58%. Comparing base (fd6640c) to head (26b750d).

Files Patch % Lines
milvus/MilvusClient.ts 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   96.61%   96.58%   -0.04%     
==========================================
  Files          36       36              
  Lines        1893     1901       +8     
  Branches      502      505       +3     
==========================================
+ Hits         1829     1836       +7     
- Misses         56       57       +1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanghaikid shanghaikid merged commit f6dddbf into main Mar 27, 2024
2 of 5 checks passed
@shanghaikid shanghaikid deleted the highlevel branch March 27, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants