Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify index name strings in db #2858

Closed
cydrain opened this issue Jul 14, 2020 · 1 comment · Fixed by #2866
Closed

unify index name strings in db #2858

cydrain opened this issue Jul 14, 2020 · 1 comment · Fixed by #2866
Assignees
@wxyucs
Labels
kind/enhancement Issues or changes related to enhancement
Projects
Improvement Request

Comments

@cydrain
Copy link
Contributor

cydrain commented Jul 14, 2020

Please state you issue using the following template and, most importantly, in English.

Describe the bug
in db/Utils.cpp, API GetIndexName()
we should not use string "IDMAP" directly, but use knowhere::IndexEnum instead.
@cydrain cydrain added the kind/enhancement Issues or changes related to enhancement label Jul 14, 2020
@cydrain cydrain added this to To do in Improvement Request via automation Jul 14, 2020
@cydrain cydrain changed the title unify index name strings unify index name strings in db Jul 14, 2020
@cydrain cydrain mentioned this issue Jul 15, 2020
Merged
Improvement Request automation moved this from To do to Done Jul 15, 2020
@cydrain cydrain reopened this Jul 15, 2020
Improvement Request automation moved this from Done to In progress Jul 15, 2020
@wxyucs
Copy link
Member

wxyucs commented Oct 19, 2020

Done

@wxyucs wxyucs closed this as completed Oct 19, 2020
Improvement Request automation moved this from In progress to Done Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wxyucs wxyucs

Labels
kind/enhancement Issues or changes related to enhancement
Projects
No open projects
Improvement Request
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add MILVUS_SUPPORT_SPTAG for some code
2 participants
@cydrain @wxyucs