Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: change default partition num to 16 when using partition key #32950

Merged
merged 1 commit into from May 13, 2024
Merged

enhance: change default partition num to 16 when using partition key #32950

merged 1 commit into from May 13, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented May 10, 2024

/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines. labels May 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 10, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 10, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented May 10, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 10, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 10, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added test/integration integration test size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels May 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 11, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented May 11, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.05%. Comparing base (c0e62e6) to head (049f0e6).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32950      +/-   ##
==========================================
- Coverage   82.07%   82.05%   -0.02%     
==========================================
  Files        1007     1007              
  Lines      127625   127647      +22     
==========================================
- Hits       104746   104739       -7     
- Misses      18908    18926      +18     
- Partials     3971     3982      +11
Files Coverage Δ
pkg/common/common.go 73.33% <ø> (ø)

... and 34 files with indirect coverage changes

@SimFG
Copy link
Contributor Author

SimFG commented May 12, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 12, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented May 13, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 13, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented May 13, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 13, 2024
@czs007
Copy link
Contributor

czs007 commented May 13, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4031abd into milvus-io:master May 13, 2024
15 checks passed
@congqixia congqixia added the behavior-change pr has behavior change label May 15, 2024
congqixia added a commit to congqixia/milvus-sdk-go that referenced this pull request May 15, 2024
@congqixia
fix: Sync default partition number to 16
b14c6f4 
See also milvus-io/milvus#32950

Default partition number is updated to 16 which caused some case failed

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this pull request May 15, 2024
Merged
sre-ci-robot pushed a commit to milvus-io/milvus-sdk-go that referenced this pull request May 15, 2024
@congqixia
fix: Sync default partition number to 16 (#747)
785bac6 
See also milvus-io/milvus#32950

Default partition number is updated to 16 which caused some case failed

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

@xige-16 xige-16 Awaiting requested review from xige-16

Assignees

@czs007 czs007

Labels
approved area/test behavior-change pr has behavior change ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm sig/testing size/S Denotes a PR that changes 10-29 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SimFG @czs007 @sre-ci-robot @congqixia