Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Search did not return enough result after segment compaction #33227

Closed
1 task done
MrPresent-Han opened this issue May 21, 2024 · 4 comments
Closed
1 task done
Assignees
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@MrPresent-Han
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:master
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

topK=10, but only get 9 entities after searching for e2e test:
testcases/test_compaction.py::TestCompactionOperation::test_compact_during_insert

Expected Behavior

get correct number

Steps To Reproduce

testcases/test_compaction.py::TestCompactionOperation::test_compact_during_insert

Milvus Log

No response

Anything else?

No response

@MrPresent-Han MrPresent-Han added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 21, 2024
@MrPresent-Han
Copy link
Contributor Author

[2024/05/21 07:13:51.227 +00:00] [DEBUG] [delegator/delegator.go:210] ["search segments..."] [traceID=b05f6489734a7a42d63ecd8de59ebf3c] [collectionID=449910774687176412] [channel=by-dev-rootcoord-dml_2_449910774687176412v0] [replicaID=449910802170512138] [sealedNum=1] [growingNum=0]

only searched single one segment and proxy only got result from one shard:

[2024/05/21 07:13:51.237 +00:00] [DEBUG] [proxy/search_reduce_util.go:280] [subSearchResultData] [traceID=b05f6489734a7a42d63ecd8de59ebf3c] ["result No."=0] [nq=1] [topk=10] ["length of pks"=9] ["length of FieldsData"=0]

So there's only one possibility that the result from that segment was already 9 entities

@xiaofan-luan
Copy link
Contributor

this could happen with duplicated pk

@yanliang567
Copy link
Contributor

@MrPresent-Han is this the same to #33297
/assign @MrPresent-Han
/unassign

@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 23, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.3, 2.5.0 May 23, 2024
@congqixia
Copy link
Contributor

Shall be fixed by #33359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants