Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Nightly] The accuracy of range search using FLOAT16_VECTOR is lower than expected #33512

Open
1 task done
NicoYuan1986 opened this issue May 31, 2024 · 3 comments
Open
1 task done
Assignees
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@NicoYuan1986
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 23dedc2
- Deployment mode(standalone or cluster):cluster
- MQ type(rocksmq, pulsar or kafka):    pulsar
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

The accuracy of range search using FLOAT16_VECTOR is lower than expected.

[2024-05-30T19:43:22.211Z]             hit_rate = round(len(set(ids).intersection(set(range_ids))) / len(set(ids)), 2)
[2024-05-30T19:43:22.211Z]             log.debug(f"range search results with growing {bool(i % 2)} hit rate: {hit_rate}")
[2024-05-30T19:43:22.211Z] >           assert hit_rate >= 0.2    # issue #32630 to improve the accuracy
[2024-05-30T19:43:22.211Z] E           assert 0.18 >= 0.2

Expected Behavior

improve the accuracy

Steps To Reproduce

1. create collection, insert 8000 vectors,
2. search with topk=1000
3. range search from the 30th-330th distance as filter
4. verified the range search results is same as the search results in the range

Milvus Log

  1. link: https://jenkins.milvus.io:18080/blue/organizations/jenkins/Milvus%20Nightly%20CI/detail/master/758/pipeline/243/
  2. log: artifacts-milvus-distributed-pulsar-nightly-758-pymilvus-e2e-logs.tar.gz
  3. collection name: search_collection_EWTw9Xmm
  4. failed time: [2024-05-30T18:50:58.290Z] [gw1] [ 64%] FAILED testcases/test_search.py::TestCollectionRangeSearch::test_range_search_default[IVF_PQ-L2-FLOAT16_VECTOR]

Anything else?

No response

@NicoYuan1986 NicoYuan1986 added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 31, 2024
@NicoYuan1986 NicoYuan1986 added this to the 2.5.0 milestone May 31, 2024
@xiaofan-luan
Copy link
Contributor

hit rate 0.2 is too low.
why the test assert hit rate > 0.2?

@xiaofan-luan
Copy link
Contributor

and I don't think this is related to fp16.
Either this is not a valid test, or this is a bug of range search, not fp16

@yanliang567
Copy link
Contributor

I agree that this is an issue about range search #32630
/assign @liliu-z

@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 7, 2024
@yanliang567 yanliang567 removed their assignment Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants