Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update check for sparse hnsw index #33713

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix: update check for sparse hnsw index #33713

merged 1 commit into from
Jul 2, 2024

Conversation

zhengbuqian
Copy link
Collaborator

issue: #29419

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 7, 2024
@zhengbuqian zhengbuqian mentioned this pull request Jun 7, 2024
Merged
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jun 7, 2024
@zhengbuqian
Copy link
Collaborator Author

/hold

czs007 pushed a commit that referenced this pull request Jun 7, 2024
@zhengbuqian
fix: [2.4] update check for sparse hnsw index (#33714)
39e341e 
issue: #29419
pr: #33713

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
buqian-zilliz pushed a commit to zhengbuqian/milvus that referenced this pull request Jun 11, 2024
@zhengbuqian
fix: [2.4] update check for sparse hnsw index (milvus-io#33714)
6ebfd0c 
issue: milvus-io#29419
pr: milvus-io#33713

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@zhengbuqian
Copy link
Collaborator Author

/unhold

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 11, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (51ebe95) to head (3b7ae10).
Report is 32 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33713      +/-   ##
==========================================
+ Coverage   81.01%   81.03%   +0.01%     
==========================================
  Files        1077     1077              
  Lines      137194   137210      +16     
==========================================
+ Hits       111153   111188      +35     
+ Misses      21829    21803      -26     
- Partials     4212     4219       +7
Files Coverage Δ
internal/proxy/task_index.go 79.96% <100.00%> (+0.16%) ⬆️
pkg/common/common.go 79.59% <ø> (ø)
pkg/util/indexparamcheck/base_checker.go 95.45% <100.00%> (+4.54%) ⬆️

... and 37 files with indirect coverage changes

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Jun 25, 2024
@zhengbuqian
fix: update check for sparse hnsw index
3b7ae10 
issue: milvus-io#29419

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@mergify mergify bot added ci-passed and removed ci-passed labels Jun 27, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 2, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fa8d641 into milvus-io:master Jul 2, 2024
12 checks passed
@zhengbuqian zhengbuqian deleted the sparse-milvus-check branch July 3, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhengbuqian @czs007 @sre-ci-robot