Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: do check when add not empty logpath(#33640) #34212

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Jun 26, 2024

pr: #33640

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 26, 2024
Copy link
Contributor

mergify bot commented Jun 26, 2024

@smellthemoon Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Jun 26, 2024
@smellthemoon
Copy link
Contributor Author

pr: #33640

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.96%. Comparing base (07a05db) to head (b4289d3).
Report is 7 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34212      +/-   ##
==========================================
- Coverage   82.04%   81.96%   -0.09%     
==========================================
  Files        1007     1012       +5     
  Lines      130600   130264     -336     
==========================================
- Hits       107155   106765     -390     
- Misses      19455    19492      +37     
- Partials     3990     4007      +17     
Files Coverage Δ
internal/datacoord/segment_info.go 87.30% <ø> (ø)
internal/metastore/kv/datacoord/util.go 61.11% <100.00%> (+0.48%) ⬆️

... and 222 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jun 26, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jun 27, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jun 27, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 1, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a3fdd02 into milvus-io:2.4 Jul 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants