-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: do check when add not empty logpath(#33640) #34212
Conversation
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
@smellthemoon Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
pr: #33640 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #34212 +/- ##
==========================================
- Coverage 82.04% 81.96% -0.09%
==========================================
Files 1007 1012 +5
Lines 130600 130264 -336
==========================================
- Hits 107155 106765 -390
- Misses 19455 19492 +37
- Partials 3990 4007 +17
|
@smellthemoon E2e jenkins job failed, comment |
/run-cpu-e2e |
@smellthemoon E2e jenkins job failed, comment |
/run-cpu-e2e |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, smellthemoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pr: #33640