Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support query return vector output field #6570

Merged
merged 14 commits into from Jul 16, 2021
Merged

Support query return vector output field #6570

merged 14 commits into from Jul 16, 2021

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Jul 15, 2021

Resolves: #6299
Signed-off-by: yudong.cai yudong.cai@zilliz.com

@cydrain
improve code readibility
f73db2f 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
add offset in RetrieveResults
2be900a 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
add VectorFieldInfo into Segment struct
cc889a8 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
add new interface for query vector
e32d04e 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
update load vector field logic
c236ef8 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
update load vector field logic
a271030 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
fill in field name in query result
dadb51c 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
add FieldId into FieldData
1dfc64a 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
add fillVectorOutputFieldsIfNeeded
3ae1f04 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
update data_codec_test.go
f561257 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
add DeserializeFieldData
cc9aafa 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
realize query return vector output field
6d6e543 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
fix static-check
af81e19 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@sre-ci-robot sre-ci-robot added component/querynode size/XXL Denotes a PR that changes 1000+ lines. labels Jul 15, 2021
@cydrain
disable query vector case
46ae9fe 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@mergify mergify bot added the ci-passed label Jul 16, 2021
@neza2017
Copy link
Contributor

/lgtm

@neza2017
Copy link
Contributor

/cc @xige-16

@xige-16
Copy link
Contributor

xige-16 commented Jul 16, 2021

any unit test on this fix?

@cydrain
Copy link
Contributor Author

cydrain commented Jul 16, 2021 •
edited

@xige-16
This is system level functionality, unit test cannot cover.
I have asked tester team to add cases to cover this.

@cydrain
Copy link
Contributor Author

cydrain commented Jul 16, 2021

/hold

@cydrain
Copy link
Contributor Author

cydrain commented Jul 16, 2021

/unhold

@xige-16
Copy link
Contributor

xige-16 commented Jul 16, 2021

/lgtm
/appove

@neza2017
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, neza2017

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a992dcf into milvus-io:master Jul 16, 2021
@cydrain cydrain deleted the caiyd_6299_support_query_vector branch July 17, 2021 07:19
@cydrain cydrain self-assigned this Jul 31, 2021
@xiaofan-luan xiaofan-luan mentioned this pull request Aug 18, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@fishpenguin fishpenguin Awaiting requested review from fishpenguin

@FluorineDog FluorineDog Awaiting requested review from FluorineDog

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@sunby sunby Awaiting requested review from sunby

@xige-16 xige-16 Awaiting requested review from xige-16

Assignees

@cydrain cydrain

@xige-16 xige-16

@neza2017 neza2017

Labels
approved area/test ci-passed lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support query vector field
4 participants
@cydrain @neza2017 @xige-16 @sre-ci-robot