feat: Add sparse float vector support to PyMilvus #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @zhengbuqian! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
1 task
buqian-zilliz
force-pushed
the
sparse-vector
branch
from
81baaaa
to
64770eb
Compare
buqian-zilliz
force-pushed
the
sparse-vector
branch
from
64770eb
to
09233bc
Compare
1 task
zhengbuqian
force-pushed
the
sparse-vector
branch
from
09233bc
to
abf1f6d
Compare
zhengbuqian
changed the title
zhengbuqian
force-pushed
the
sparse-vector
branch
2 times, most recently
from
24b1b15
to
124b9af
Compare
buqian-zilliz
force-pushed
the
sparse-vector
branch
2 times, most recently
from
bfafae2
to
ca6712c
Compare
buqian-zilliz
force-pushed
the
sparse-vector
branch
2 times, most recently
from
6a57c9a
to
929a266
Compare
|
/hold reviewer please review, but I'll wait until all milvus PRs(expecting by Wednesday) before merging this one. |
czs007
reviewed
Mar 11, 2024
| @@ -456,11 +456,11 @@ def _pre_batch_check( | |||
| fields_info: Any, | |||
| ): | |||
| for entity in entities: | |||
| if ( | |||
| not entity.get("name", None) | |||
| or not entity.get("values", None) | |||
There was a problem hiding this comment.
or entity.get("values", None) is None
buqian-zilliz
force-pushed
the
sparse-vector
branch
from
929a266
to
2e4b44d
Compare
|
/approve |
buqian-zilliz
force-pushed
the
sparse-vector
branch
from
2e4b44d
to
c3c4ff3
Compare
|
hold until milvus PR is merged |
|
/unhold all required milvus PRs are merged |
…rts various sparse matrix representations also supported row based insertion so sparse is also supported in milvus client Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
buqian-zilliz
force-pushed
the
sparse-vector
branch
from
c3c4ff3
to
3051ed8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, XuanYang-cn, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the basic sparse float vector support to pymilvus.
The following types of input are supported:
scipy.sparsematrix/array class family[{0: 0.3, 20: 0.5}, {4: 0.4}, ...][[(0, 0.3), (20, 0.5)], [(4, 0.4)], ...]Sparse float vector support tracking issue: milvus-io/milvus#29419