Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restrict input/search type for vector fields #2025

Merged
merged 2 commits into from
Apr 10, 2024
Merged

fix: restrict input/search type for vector fields #2025

merged 2 commits into from
Apr 10, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #2018, #2004, #2016

@XuanYang-cn
fix: restrict input/search type for vector fields
b630638 
See also: milvus-io#2018, milvus-io#2004, milvus-io#2016

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify mergify bot added the dco-passed label Apr 9, 2024
@XuanYang-cn
fix ut
375d1bd 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify mergify bot added the ci-passed label Apr 9, 2024
@XuanYang-cn
Copy link
Contributor Author

image

longjiquan
longjiquan approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longjiquan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuanYang-cn,longjiquan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ea2c9c6 into milvus-io:master Apr 10, 2024
9 checks passed
@XuanYang-cn XuanYang-cn deleted the enhance/add-flush-ts branch April 10, 2024 06:39
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Apr 10, 2024
@XuanYang-cn
fix: [cherry-pick]restrict input/search type for vector fields (milvu…
b661c26 
…s-io#2025)

See also: milvus-io#2018, milvus-io#2004, milvus-io#2016

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Apr 10, 2024
@XuanYang-cn
fix: [cherry-pick]restrict input/search type for vector fields (#2025) (
ad1fb25 
#2029)

See also: #2018, #2004, #2016

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn added PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x and removed PR | cherry-pick to 2.x labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longjiquan longjiquan longjiquan approved these changes

@czs007 czs007 Awaiting requested review from czs007

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees

@longjiquan longjiquan

Labels
approved ci-passed dco-passed lgtm PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XuanYang-cn @sre-ci-robot @longjiquan