Open wallet should restart node if chain types don't match #12
Conversation
…lue of Wallet use_embedded_node.
… variable. The wallet config shall also have an optional node_url and secret_path.
…et chain do not match.
…allet. ...vscode auto formatting
…d for the wallet.
| node_url: None, | ||
| secret_path: None, | ||
| } | ||
| } |
There was a problem hiding this comment.
Just an observation that we're going to have to think a bit about how much we store in the gui's config file vs the wallet's config file. Technically all of these fields (other than use_embedded_node) are already stored in the wallet's config file, so perhaps the gui code should be using/modifying (and allowing the user to configure) those instead of repeating them? This is fine for now to get us going since we don't have code in place to modify config files yet, (we'll want it soon,) but we should be keeping this in mind.
There was a problem hiding this comment.
in any case, getting and using the chain type is better than an is_testnet flag
|
All good, just an observation above and a small change requested to mimblewimble/grin#3737. |
More bug fixes. Restart of node server will not work without global edits.
mimblewimble/grin#3737.
I also, fixed an overflow bug in that merge for new wallets.