Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo warning when updating grin crates #533

Closed
antiochp opened this issue Nov 25, 2020 · 2 comments
Closed

cargo warning when updating grin crates #533

antiochp opened this issue Nov 25, 2020 · 2 comments

Comments

@antiochp
Copy link
Member

Saw the following warning when updating grin crates to latest master on grin-wallet -

cargo update -p grin_core
    Updating git repository `https://github.com/mimblewimble/grin`
    Updating crates.io index
warning: two git dependencies found for `https://github.com/mimblewimble/grin` 
where one uses `branch = "master"` and the other doesn't; 
this will break in a future version of Cargo, so please ensure the dependency forms are consistent

Have not investigated exactly what is going on. But we should fix this sooner rather than later.

@trevyn
Copy link
Contributor

trevyn commented Mar 16, 2021

This appears to be fixed by 7896001 on Dec 1.

With cargo 1.50, I can reproduce the warning at the previous commit c3481a3, but not at 7896001.

The commit includes several copies of this change to Cargo.lock, adding branch=master:

- source = "git+https://github.com/mimblewimble/grin#48efb693e2e5cdf60449b7f009214491d5bf3646"
+ source = "git+https://github.com/mimblewimble/grin?branch=master#f48a23655ded65285ab412ad22b8f6a7a0075e56"

This is apparently related to a change in how cargo handles the default branch and the master vs main change, see rust-lang/cargo#8522 for pointers to all of the exciting details.

@quentinlesceller
Copy link
Member

Thanks for investigating @trevyn, I can also confirm it does not happen anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants