Change EncryptedRequest 'id' field to String #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally, tests are consistently failing due to croaring. |
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
* change ID field in encrypted request/response to be a string of any kind * Use JsonId Enum instead of String value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Replaces #334, with a saner commit history)
In doing some sample code for the V3 API, it became evident that the ID field in encrypted requests shouldn't be restricted to being a u64, or a string representation of a u64. It should allow all types of IDs in so long as they're strings, including UUIDs.
This changes the EncryptedRequest/Response fields to type String, and provides a custom legacy serializer to ensure anyone currently sending ids as ints won't be affected by the change.