Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove V2 Slate, Add V4 #354

Merged
merged 5 commits into from
Mar 6, 2020
Merged

Remove V2 Slate, Add V4 #354

merged 5 commits into from
Mar 6, 2020

Conversation

yeastplume
Copy link
Member

In anticipation of any slate changes for 4.0.0, this:

  • Adds a V4 Slate and sets it as the default. V4 is currently exactly the same as V3.
  • Removes the V2 Slate (no longer in use since HF2 and v3.0.0)
  • Updates doctests, etc
  • Inserts a deprecated warning as a reminder where the code needs to explicitly handle any differences between V3 and V4 Slates.

@yeastplume yeastplume merged commit 1810854 into mimblewimble:master Mar 6, 2020
@yeastplume yeastplume deleted the slate_v4 branch March 13, 2020 10:25
antiochp pushed a commit to antiochp/grin-wallet that referenced this pull request Aug 7, 2020
@yeastplume
Remove V2 Slate, Add V4 (mimblewimble#354)
2eab38b 
* add V4 slate

* add V4 slate

* deprecation warnings as reminders

* fix doctests, add warnings and change upstream grin back to master
bayk added a commit to mwcproject/mwc-wallet that referenced this pull request Dec 4, 2020
@bayk
Cherrypick for:
b1281c8 
Remove V2 Slate, Add V4 (mimblewimble#354)
* add V4 slate
* add V4 slate
* deprecation warnings as reminders
* fix doctests, add warnings and change upstream grin back to master

MWC update:
V2 slate is kept and we are keeping the current approach when wallet is using the minimum slate version that is needed to satisfy the features.
bayk added a commit to mwcproject/mwc-wallet that referenced this pull request Dec 4, 2020
@bayk
Remove V2 Slate, Add V4 (mimblewimble#354)
ee59bbc 
* add V4 slate
* add V4 slate
* deprecation warnings as reminders
* fix doctests, add warnings and change upstream grin back to master
(cherry picked from commit 1810854)

Note: For MWC we are keeping V2 slate and allways use least needed slate version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaspervdm jaspervdm jaspervdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yeastplume @jaspervdm