Make Transaction Field in V4 Slate Optional #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaspervdm
reviewed
Mar 10, 2020
jaspervdm
approved these changes
Mar 10, 2020
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
* make transaction field in V4 Slate optional * add mutable/non mutable version of tx getter * removal of mut references where not needed * remove more muts * update from master * update from master * test fixes
bayk
added a commit
to mwcproject/mwc-wallet
that referenced
this pull request
Jul 21, 2024
…onal (mimblewimble#356) * make transaction field in V4 Slate optional * add mutable/non mutable version of tx getter * removal of mut references where not needed * remove more muts * update from master * update from master * test fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation of experimentation related to #317, this:
txfield in the V4 Slate to be anOption<Transaction>as opposed to aTransactiontx_or_error()function to the Slate, and use that in all places where the transaction was read from the slate directly. This will help ensure that the transaction is always populated where it's expected to be populated (i.e. everywhere, currently,) Any future cases in which Slates can be used in a 'reduced' form can be handled specially.This shouldn't have any effect on the format of serialized slates, and from an external perspective, nothing should change other than slates being able to de/serialize without the Transaction field present. (Should add a test for this)