Stop proxy in controller tests to allow dir cleanup on Windows #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaspervdm
changed the title
yeastplume
approved these changes
Mar 10, 2020
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
…ewimble#363) * Stop wallet proxy in controller tests to allow directory cleanup in Windows * Update test client * Update to latest grin master * is_unspent -> get_unspent
bayk
pushed a commit
to mwcproject/mwc-wallet
that referenced
this pull request
Dec 5, 2020
…ewimble#363) * Stop wallet proxy in controller tests to allow directory cleanup in Windows * Update test client * Update to latest grin master * is_unspent -> get_unspent (cherry picked from commit 63eb25a)
bayk
added a commit
to mwcproject/mwc-wallet
that referenced
this pull request
Jul 21, 2024
… dir cleanup on Windows (mimblewimble#363) * Stop wallet proxy in controller tests to allow directory cleanup in Windows * Update test client * Update to latest grin master * is_unspent -> get_unspent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most tests didn't actually stop the wallet proxy thread, blocking files in the test directory and preventing them from being deleted on Windows. This PR triggers the stop in each of the tests