Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slatepack Address HRP #436

Merged
merged 4 commits into from
Jun 12, 2020
Merged

Slatepack Address HRP #436

merged 4 commits into from
Jun 12, 2020

Conversation

yeastplume
Copy link
Member

@yeastplume yeastplume commented Jun 11, 2020

Calling it.

  • grin1 on mainnet
  • tgrin1 for floonet or any other testing chain type

(Last change before beta.2, and last intended functional change for 4.0.0 overall)

@yeastplume yeastplume changed the title Slatepack address HRP Slatepack Address HRP Jun 11, 2020
Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Minor comment on a possible "Regnet" style addresses

libwallet/src/slatepack/address.rs Show resolved Hide resolved
Copy link
Member

@j01tz j01tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for getting this in. I'll update the RFC accordingly.

@yeastplume yeastplume merged commit ff9a9ea into mimblewimble:master Jun 12, 2020
@yeastplume yeastplume deleted the hrp branch July 13, 2020 10:20
antiochp pushed a commit to antiochp/grin-wallet that referenced this pull request Aug 7, 2020
* slatepack address hrp

* fix prefix

* test updates

* fix libwallet tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants