Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip Tor send attempts in TorConfig #453

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

yeastplume
Copy link
Member

Addresses #451. This is really the only non-breaking way to implement this (anything else would mean adding parameters to the receive_tx foreign API function, which would break backwards compatibility.

  • Adds a skip_send_attempt field to the TorConfig struct. If set to Some(true), the slatepack workflow will skip the Tor send attempt.
  • To turn off TOR sends, via the API's, use the set_tor_config API function (included in both the Owner and Foreign APIs), setting skip_send_attempt to true
  • In addition, all command-line functions that can send via Tor now take a --manual, -m flag. If present, the Tor send attempt will be skipped.

@yeastplume yeastplume merged commit 99c2505 into mimblewimble:master Jun 24, 2020
@yeastplume yeastplume deleted the no_tor branch July 13, 2020 10:20
antiochp pushed a commit to antiochp/grin-wallet that referenced this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant