Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove method from grin-wallet.yml and keybase.rs from adapters #658

Merged
merged 4 commits into from Jul 26, 2022

Conversation

s7500
Copy link
Contributor

@s7500 s7500 commented Jul 22, 2022

This PR solves part of the issue
Doesn't break consensus
No additional unit tests needed
All tests passed

@phyro
Copy link
Member

phyro commented Jul 22, 2022

Thanks for the contribution @s7500 . I'll take a look into it a bit more later when I get to my PC. One thing that comes to mind is that removing keybase adapter would also require removing keybase_notify_ttl config option.

@s7500
Copy link
Contributor Author

s7500 commented Jul 22, 2022

Thanks @phyro, that's a good note!
I also removed it in the new commit

@phyro
Copy link
Member

phyro commented Jul 22, 2022

Note that there are still some keybase_notify_ttl occurrences left in the codebase

@s7500
Copy link
Contributor Author

s7500 commented Jul 22, 2022

Sorry, my mistake
I should trust my ide less

@yeastplume
Copy link
Member

Looks good, thanks for this. I remember it being annoying having to maintain that unused keybase adapter, so happy to have it removed from the code.

@yeastplume yeastplume merged commit 67f0e2b into mimblewimble:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants