Update tokio to v1 and reqwest to v0.11 #686
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this is likely to be a major upgrade that will need attention to what's changed as well as quite a bit of testing, let's see what errors it comes back with. Note we don't need this right now cause #685 fixes our current issues, but we likely want to do this soon, perhaps we can do a release soon then look at this right after? |
|
Yes absolutely. And indeed looks like #685 solved the CI issue. Agree to pause this until next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the build issue we currently have on Windows. This PR update:
I'm expecting that some tests might not pass as this is a major upgrade.Locally all tests are passing.